Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 12/27/16 9:53 AM, Jan Beulich wrote:
>>>> "Jan Beulich" <jbeulich@xxxxxxxx> 12/27/16 4:42 PM >>>
>>>> Alistair Francis <alistair.francis@xxxxxxxxxx> 12/22/16 8:14 PM >>>
>>> Everyone seems fairly open to an override. Is a environment variable,
>>> which if set will disable Werror acceptable? Something like NO_ERROR=Y
>>> which will result in no -Werror being appended.
>>
>> I dislike environment variables for such purposes, and would prefer requiring
>> such to be added as make options. If it was an environment variable, it
>> should start with XEN_. And its name should fully reflect the purpose, i.e. I
>> shouldn't have to guess what kinds of errors would be suppressed. Perhaps
>> WARN_NO_ERROR?
> 
> That said, I'm not sure everyone agreed on putting an override in place. I 
> think
> Andrew had made it quite clear that there is a reason for -Werror to be in 
> use,
> and we shouldn't encourage people weakening code by tolerating warnings
> (even if for the purpose of upstream integration no warnings will be permitted
> anyway, due to -Werror remaining the default).
> 
> Jan
> 

That was for the hypervisor bits. Anything that relies on user space
code and headers that will be provided by the distro should be able to
build with -Werror. That's something all distros have to patch out and
is downstream hostile to do since a different toolchain than what the
developers use can generate warnings or slight different dependencies an
generate them.

-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel