Re: [Xen-devel] [PATCH] tools/tests/x86_emulate: #define unlikely in x86 emulator test harness

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 22/12/16 14:58, Ian Jackson wrote:
> "x86emul: in_longmode() should not ignore ->read_msr() errors" aka
> c/s 122dd9575c7a introduced a use of unlikely() in
> xen/arch/x86/x86_emulate/x86_emulate.c.
>
> I think this is probably intentional and fine.  However, there is no
> definition of unlikely in the x86 emulator test harness, under tools.
>
> The result is this error:
>    x86_emulate/x86_emulate.c: In function 'in_longmode':
>    x86_emulate/x86_emulate.c:1300:10: error: implicit declaration of function 
> 'unlikely' [-Werror=implicit-function-declaration]
>              unlikely(ops->read_msr(MSR_EFER, &efer, ctxt) != X86EMUL_OKAY) )
>              ^~~~~~~~
>
> Fix this by providing a boring definition of unlikely().
>
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
This was fixed by 3e84c8da7d2c5442a12789dae7163dca6c0e154f

Part of that should backported to 4.8, where it is still broken.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel