Re: [Xen-devel] [XTF PATCH 07/16] vvmx: test vmxon in CPL=3 and out of VMX operation

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 19/12/16 03:35, Haozhong Zhang wrote:
>
>>> +{
>>> +    clear_vmcs(vmxon_region, get_vmcs_revid());
>>> +
>>> +    unsigned long ret = exec_user(vmxon_in_user);
>>> +    uint8_t err = (ret >> 32) & 0xff;
>>> +    exinfo_t fault = ret & 0xFFFFFFFF;
>>> +
>>> +    return handle_vmxinsn_err(__func__, err, fault,
>>> +                              VMXERR_FAULT, EXINFO_SYM(GP, 0), 0);
>>> +}
>>> +
>>>  bool test_vmxon(void)
>>>  {
>>>      if ( !test_vmxon_novmxe() )
>>>          return false;
>>
>> Your subject says out of VMX operation, but the implementation is inside
>> VMX operation.
>>
>
> vmxon in test_vmxon_novmxe() fails if test_vmxon_novmxe() return true,
> so here we are still out of VMX operation.

Very good point.  Its obvious now you point it out.  Sorry for the noise.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel