Re: [Xen-devel] [PATCH 1/8] libelf: loop safety: Introduce elf_iter_ok and elf_strcmp_safe

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.12.16 at 17:04, <ian.jackson@xxxxxxxxxxxxx> wrote:
> Jan Beulich writes ("Re: [PATCH 1/8] libelf: loop safety: Introduce 
> elf_iter_ok and elf_strcmp_safe"):
>> On 12.12.16 at 17:56, <ian.jackson@xxxxxxxxxxxxx> wrote:
>> > I have replaced the limit with a comment.  Now I have:
>> > 
>> >     elf->iteration_deaccumulator =
>> >         1024*1024 + size * ELF_MAX_ITERATION_FACTOR;        
>> >         /* overflow (from very big size, probably rejected earlier)
>> >          * would just lead to small limit, which is safe */
>> 
>> Thanks. May I ask that you then also use proper hypervisor
>> style for that comment?
> 
> You mean like this ?
> 
>     elf->iteration_deaccumulator =
>         1024*1024 + size * ELF_MAX_ITERATION_FACTOR;
>         /*
>          * overflow (from very big size, probably rejected earlier)
>          * would just lead to small limit, which is safe
>          */
> 
> Sure, whatever.  Done.

Almost: Comments are also supposed to start with an upper
case letter. But I'm fine either way.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel