Re: [Xen-devel] [PATCH v2 2/9] Osstest: Add target_cmd_output_root_status

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Konrad Rzeszutek Wilk writes ("[PATCH v2 2/9] Osstest: Add 
target_cmd_output_root_status"):
> Which is similar to target_cmd_root_status except it outputs
> both return value _and_ output.
> 
> To make this work we expose the $backstatusok in tcmdout
> sub-routine and if set - return the value and output.

This function's calling conventions have become rather more complex
now, and it was already rather more complicated than is ideal for a
function with no calling convention comment.

Could you add such a comment please ?  You'll find various examples of
suitable styles.

The code itself is fine by me.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel