Re: [Xen-devel] [PATCH v4 1/2] tools/libacpi: update FADT layout to support version 5

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.12.16 at 17:04, <roger.pau@xxxxxxxxxx> wrote:
> Update the structure of the FADT table to version 5, and use that version for
> PVHv2 guests. Note that HVM guests will continue to use FADT 4. In order to do
> this, add a new field to acpi_config that contains the ACPI revision to use by
> libacpi. Note that currently this only applies to the FADT.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

To be honest I'm of two minds here. On one hand the patch is fine
as is for the immediate purpose. On the other hand I would have
hoped for a little more complete handling of this:
- The spec is at version 6.1 - I don't see why we should give anything
  less to PVHv2 guests, causing possible compatibility issues going
  forward.
- The version consists of both a major and a minor part, yet no
  provisions are being made to allow for this.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel