Re: [Xen-devel] [RFC XEN PATCH 03/16] xen/x86: add a hypercall XENPF_pmem_add to report host pmem regions

[Haozhong Zhang <haozhong.zhang@xxxxxxxxx>]

On 12/12/16 09:44 -0500, Konrad Rzeszutek Wilk wrote:
> On Mon, Dec 12, 2016 at 04:38:38PM +0800, Haozhong Zhang wrote:
> > On 12/12/16 01:30 -0700, Jan Beulich wrote:
> > > > > > On 12.12.16 at 05:16, <haozhong.zhang@xxxxxxxxx> wrote:
> > > > On 12/09/16 17:02 -0500, Konrad Rzeszutek Wilk wrote:
> > > > > On Mon, Oct 10, 2016 at 08:32:22AM +0800, Haozhong Zhang wrote:
> > > > > > +static int pmem_add_check(unsigned long spfn, unsigned long epfn,
> > > > > > +                          unsigned long rsv_spfn, unsigned long 
> > rsv_epfn,
> > > > > > +                          unsigned long data_spfn, unsigned long 
> > data_epfn)
> > > > > > +{
> > > > > > +    if ( spfn >= epfn || rsv_spfn >= rsv_epfn || data_spfn >= 
> > data_epfn )
> > > > > > +        return 0;
> > > > >
> > > > > Hm, I think it ought to be possible to have no rsv area..?
> > > >
> > > > A reserved area must be provided to storing frametable and M2P table of
> > > > NVDIMM.
> > >
> > > Is this really "must" rather than just "should", i.e. can't you do
> > > without even if you prefer to have it?
> > >
> > > Jan
> > >
> >
> > It's a must in this version, but I relax this requirement in the WIP
> > v2 patch that fallback to the ordinary RAM if no reserved pmem area is
> > indicated.
> Awesome! Is your v2 patch somewhere available? I was thinking to continue
> looking at your patchset later today but perhaps I should eyeball v2
> instead?
It's not ready yet, but most of your comments also apply there. The
toolstack part in v2, especially the ACPI part, is almost the same so
far.

Thanks,
Haozhong

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel