Re: [Xen-devel] [PATCH v2] AMD IOMMU: Support IOAPIC IDs larger than 128

[Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx>]

On 12/12/16 21:46, Jan Beulich wrote:
> > > > On 05.12.16 at 20:36, <suravee.suthikulpanit@xxxxxxx> wrote:
> > +unsigned int ioapic_id_to_index(unsigned int apic_id)
> > +{
> > +    unsigned int idx;
> > +
> > +    if ( !nr_ioapic_sbdf )
> > +        return MAX_IO_APICS;
> This is pointless (redundant with ...
>
> > +    for ( idx = 0 ; idx < nr_ioapic_sbdf; idx++ )
> > +        if ( ioapic_sbdf[idx].id == apic_id )
> > +            break;
> > +
> > +    if ( idx == nr_ioapic_sbdf )
> > +        return MAX_IO_APICS;
> ... this), so I think I'll take the liberty of removing it while committing.
> With that
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> And I see that you've got away without bumping the size of the
> array.
>
> Jan
Thanks Jan.

Suravee

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel