[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 5/8] libelf: loop safety: Replace all calls to strcmp
>>> On 09.12.16 at 16:44, <ian.jackson@xxxxxxxxxxxxx> wrote: > /* other */ > - if ( !strcmp(name, "FEATURES") ) > - if ( elf_xen_parse_features(value, parms->f_supported, > + if ( !elf_strcmp_safe(elf, name, "FEATURES") ) > + if ( elf_xen_parse_features(elf, value, parms->f_supported, > parms->f_required) ) > return -1; There must be some patch split problem here - this patch does not alter the parameters of elf_xen_parse_features(), so the argument list can't change here. And one of the then (at least) two patches touching this code could then take the opportunity and fold the two if()s into one. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |