Re: [Xen-devel] [PATCH 1/5] x86/traps: Drop paging_mode_external() handling from the PV pagefault path

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.12.16 at 11:43, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -1799,15 +1799,6 @@ static int fixup_page_fault(unsigned long addr, struct 
> cpu_user_regs *regs)
>      if ( in_irq() || !(regs->eflags & X86_EFLAGS_IF) )
>          return 0;
>  
> -    /* Faults from external-mode guests are handled by shadow/hap */
> -    if ( paging_mode_external(d) && guest_mode(regs) )
> -    {
> -        int ret = paging_fault(addr, regs);
> -        if ( ret == EXCRET_fault_fixed )
> -            trace_trap_two_addr(TRC_PV_PAGING_FIXUP, regs->eip, addr);
> -        return ret;
> -    }

Perhaps worthwhile leaving an ASSERT() with the inverted if()
condition here?

Anyway, with or without that
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel