Re: [Xen-devel] [PATCH 5/6] x86emul: avoid undefined behavior when dealing with 10-byte FPU operands

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 06/12/16 14:13, Jan Beulich wrote:
> Accessing an 8-byte (or perhaps just 4-byte in the test harness when
> built as 32-bit app) field to read/write 10 bytes (leveraging the
> successive field) is a latent bug, as the compiler could copy things
> around. Use the 32 bytes large SSE/AVX slot instead.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

The name mmval is now rather stale, and it would probably be better to
name it to something neutral, which is guarenteed to be large enough for
any single register we need to interact with.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel