Re: [Xen-devel] [PATCH 2/8] x86/emul: Debugging improvements to the test harness

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 05/12/16 12:00, Jan Beulich wrote:
>>>> On 05.12.16 at 11:09, <andrew.cooper3@xxxxxxxxxx> wrote:
>> @@ -47,6 +49,9 @@ static int read(
>>      unsigned int bytes,
>>      struct x86_emulate_ctxt *ctxt)
>>  {
>> +    if ( verbose )
>> +        printf("** %s(%u, %p,, %u,)\n", __func__, seg, (void *)offset, 
>> bytes);
> There appear to be two stray commas here, or do they serve a
> purpose?

Ah - that is my shorthand for omitted parameters.  It is helpful if
there are a lot of integer parameters.

~Andrew

>
> Other than that
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Jan
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel