[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 2/8] x86/head: Refactor 32-bit pgtable setup
On 12/02/2016 12:52 PM, hpa@xxxxxxxxx wrote: > On December 2, 2016 8:08:55 AM PST, Ingo Molnar <mingo@xxxxxxxxxx> wrote: >> * Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote: >> >>> On 12/02/2016 04:45 AM, Ingo Molnar wrote: >>>> * Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote: >>>> >>>>> On 10/31/2016 08:33 AM, Boris Ostrovsky wrote: >>>>>> On 10/14/2016 02:05 PM, Boris Ostrovsky wrote: >>>>>>> From: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> >>>>>>> >>>>>>> The new Xen PVH entry point requires page tables to be setup by >> the >>>>>>> kernel since it is entered with paging disabled. >>>>>>> >>>>>>> Pull the common code out of head_32.S and into pgtable_32.S so >> that >>>>>>> setup_pgtable_32 can be invoked from both the new Xen entry >> point and >>>>>>> the existing startup_32 code. >>>>>> Ping to x86 maintainers. >>>>> Pinging again. >>>>> >>>>> I will be re-sending this series at some point (it has been >> delayed by >>>>> some hypervisor changes that will be needed) but I'd like to hear >> from >>>>> x86 maintainers whether this will be acceptable before I post this >> again. >>>> Could this be done in C? >>> I suppose it could be, I haven't thought about it. >>> >>> The goal here was to simply make existing startup code available to >> others (Xen >>> guest) without changes. Are you suggesting to build page tables in C >> for the Xen >>> guest only or to make startup_32 call new C code as well? >> My suggestion would be to transform the factored out assembly code to >> C. >> >> Thanks, >> >> Ingo > It is tricky to do so safely, because at this stage almost nothing of the C > execution environment has been set up. I can still give it a try but I'd rather not tie it to this (Xen PVH) patch series. Which would leave me with two options: either keep what this patch does, leaving it as assembly (requires your ack), or have Xen code build the pages on its own. -boris _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |