Re: [Xen-devel] [PATCH v2 17/19] x86/hvm: Avoid __hvm_copy() raising #PF behind the emulators back

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 29/11/16 16:36, Jan Beulich wrote:
>>>> On 29.11.16 at 17:30, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 29/11/16 16:24, Jan Beulich wrote:
>>>>>> On 28.11.16 at 12:13, <andrew.cooper3@xxxxxxxxxx> wrote:
>>>> @@ -3012,7 +3018,10 @@ void hvm_task_switch(
>>>>                                        &tss.back_link, 
>>>> sizeof(tss.back_link), 
>> 0,
>>>>                                        &pfinfo);
>>>>          if ( rc == HVMCOPY_bad_gva_to_gfn )
>>>> +        {
>>>> +            hvm_inject_page_fault(pfinfo.ec, pfinfo.linear);
>>>>              exn_raised = 1;
>>>> +        }
>>>>          else if ( rc != HVMCOPY_okay )
>>>>              goto out;
>>>>      }
>>> There's another one a few lines down from here (storing the error
>>> code on the stack). Or did an earlier patch replace this, and I didn't
>>> notice?
>> Ah - that was a rebasing error on my behalf.  Before your TSS
>> adjustments, that was a no-fault call.
>>
>> I will fix it up.
> Okay, assuming it'll follow the same model,

Yes.  The new hunk is identical to this quoted hunk (other than
indentation).

> feel free to put my R-b then on the result.

Thanks.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel