Re: [Xen-devel] [PATCH v2 02/19] x86/emul: Drop X86EMUL_CMPXCHG_FAILED

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.11.16 at 12:13, <andrew.cooper3@xxxxxxxxxx> wrote:
> X86EMUL_CMPXCHG_FAILED was introduced in c/s d430aae25 in 2005.  Even at the
> time it alised what is now X86EMUL_RETRY (as well as what is now
> X86EMUL_EXCEPTION).  I am not sure why the distinction was considered useful
> at the time.

I have always guessed that this is so one could make them have
distinct values if need be, since "cmpxchg failure" does not
necessarily mean "retry" to all possible callers. So I'm not fully
convinced this is a good move, but I'm also not worried enough
to really object.

> It is only used twice; there is no need to call it out differently from other
> uses of X86EMUL_RETRY.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel