Re: [Xen-devel] [PATCH v2 17/19] x86/hvm: Avoid __hvm_copy() raising #PF behind the emulators back

[Tim Deegan <tim@xxxxxxx>]

At 11:13 +0000 on 28 Nov (1480331614), Andrew Cooper wrote:
> Drop the call to hvm_inject_page_fault() in __hvm_copy(), and require callers
> to inject the pagefault themselves.

This seems like it'd be easy to forget to DTRT with the fault,
especially in code being ported forward across this series.

Would it be better to have hvm_copy &c take a callback function
instead of a pfinfo pointer?

(In any case, this can have my ack for the shadow-code change.)

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel