Re: [Xen-devel] [PATCH-for-4.9 v1 4/8] dm_op: convert HVMOP_set_pci_intx_level, HVMOP_set_isa_irq_level, and...

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.11.16 at 12:55, <Paul.Durrant@xxxxxxxxxx> wrote:
>>  -----Original Message-----
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> Sent: 25 November 2016 11:50
>> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
>> Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; Wei Liu
>> <wei.liu2@xxxxxxxxxx>; Ian Jackson <Ian.Jackson@xxxxxxxxxx>; xen-
>> devel@xxxxxxxxxxxxxxxxxxxx; Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
>> Subject: Re: [Xen-devel] [PATCH-for-4.9 v1 4/8] dm_op: convert
>> HVMOP_set_pci_intx_level, HVMOP_set_isa_irq_level, and...
>> 
>> >>> On 18.11.16 at 18:14, <paul.durrant@xxxxxxxxxx> wrote:
>> > --- a/xen/arch/x86/hvm/dm.c
>> > +++ b/xen/arch/x86/hvm/dm.c
>> > @@ -105,6 +105,60 @@ static int dm_op_track_dirty_vram(struct domain
>> *d,
>> >          hap_track_dirty_vram(d, first_pfn, nr, buf.h);
>> >  }
>> >
>> > +static int dm_op_set_pci_intx_level(struct domain *d, uint8_t domain,
>> > +                                    uint8_t bus, uint8_t device,
>> > +                                    uint8_t intx, uint8_t level)
>> 
>> Btw., none of these static helper functions have any need to have
>> a dm_op_ prefix. Such disambiguation is needed only for non-
>> static ones.
> 
> It make it easier to find them quickly with cscope, but I can drop the 
> prefix if you prefer.

Thanks.

>> > +static int dm_op_set_pci_link_route(struct domain *d, uint8_t link,
>> > +                                    uint8_t isa_irq)
>> > +{
>> > +    if ( link > 3 || isa_irq > 15 )
>> > +        return -EINVAL;
>> > +
>> > +    hvm_set_pci_link_route(d, link, isa_irq);
>> > +
>> > +    return 0;
>> > +}
>> 
>> In the hvmctl series I did specifically avoid to create this trivial a
>> wrapper for a function with no other callers. Simply move the
>> argument range checks there.
> 
> Ok, I'll inline in the switch if you prefer that style.

I didn't mean to inline the above in the case statement, but to
move the argument checking to hvm_set_pci_link_route() (and
call it directly from the case statement).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel