Re: [Xen-devel] [PATCH 03/15] x86/emul: Rename hvm_trap to x86_event and move it into the emulation infrastructure

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 23/11/16 16:12, Paul Durrant wrote:
>> diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c
>> index f24e211..d0c3185 100644
>> --- a/xen/arch/x86/hvm/emulate.c
>> +++ b/xen/arch/x86/hvm/emulate.c
>> @@ -1679,7 +1679,7 @@ static int hvmemul_invlpg(
>>           * violations, so squash them.
>>           */
>>          hvmemul_ctxt->exn_pending = 0;
>> -        hvmemul_ctxt->trap = (struct hvm_trap){};
>> +        hvmemul_ctxt->trap = (struct x86_event){};
> Can't say I like that way of initializing but...
>
> Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

Think of it like memcpy/memset, but typesafe.  Either way, this is a
strict renaming patch, I wouldn't want to change the method of
initialisation here anyway.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel