Re: [Xen-devel] [PATCH 1/2] build system: Include SeaBIOS and TianoCore directory

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Nov 22, 2016 at 11:02:04PM -0500, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 23, 2016 at 02:39:35AM +0000, Wei Liu wrote:
> > On Sun, Nov 20, 2016 at 10:27:21PM -0500, Konrad Rzeszutek Wilk wrote:
> > > The release source did not include those two directories.
> > > 
> > > Signed-off-by: Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>
> > > ---
> > >  tools/misc/mktarball | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/tools/misc/mktarball b/tools/misc/mktarball
> > > index 73282b5..7942846 100755
> > > --- a/tools/misc/mktarball
> > > +++ b/tools/misc/mktarball
> > > @@ -35,6 +35,11 @@ git_archive_into 
> > > $xen_root/tools/qemu-xen-traditional-dir-remote $tdir/xen-$desc
> > >  
> > >  git_archive_into $xen_root/extras/mini-os-remote 
> > > $tdir/xen-$desc/extras/mini-os
> > >  
> > > +git_archive_into $xen_root/tools/firmware/seabios-dir-remote 
> > > $tdir/xen-$desc/tools/firmware/seabios-dir
> > > +
> > > +if [ -d $xen_root/tools/firmware/ovmf-dir-remote ]; then
> > 
> > Is this test really needed? I think subtree-force-update-all will clone
> > ovmf anyway.
> 
> I think it only does that if CONFIG_OVMF is in your local .config -
> which is only the case if you run ./configure --enable-ovmf
> 

In that case, shouldn't seabios and rombios be treated the same way?

> 
> > 
> > > +    git_archive_into $xen_root/tools/firmware/ovmf-dir-remote 
> > > $tdir/xen-$desc/tools/firmware/ovmf-dir
> > > +fi
> > >  GZIP=-9v tar cz -f $xen_root/dist/xen-$desc.tar.gz -C $tdir xen-$desc
> > >  
> > >  echo "Source tarball in $xen_root/dist/xen-$desc.tar.gz"
> > > -- 
> > > 2.9.3
> > > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxx
> > https://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel