Re: [Xen-devel] [PATCH] x86/hvm: Fix non-debug build folling c/s 0745f665a5

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Nov 21, 2016 at 11:06:23AM -0500, Boris Ostrovsky wrote:
> On 11/21/2016 10:32 AM, Andrew Cooper wrote:
> > The variable is named inst_len, not insn_len.
> >
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > ---
> > CC: Jan Beulich <JBeulich@xxxxxxxx>
> > CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> > CC: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> > CC: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> >
> > I definitely fixed this once duing development, but it clearly slipped back
> > in.  My appologies.
> > ---
> >  xen/arch/x86/hvm/svm/emulate.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/xen/arch/x86/hvm/svm/emulate.c b/xen/arch/x86/hvm/svm/emulate.c
> > index ca670bf..2b47db9 100644
> > --- a/xen/arch/x86/hvm/svm/emulate.c
> > +++ b/xen/arch/x86/hvm/svm/emulate.c
> > @@ -98,8 +98,8 @@ int __get_instruction_length_from_list(struct vcpu *v,
> >       */
> >  #ifdef NDEBUG
> >      if ( (inst_len = svm_nextrip_insn_length(v)) > MAX_INST_LEN )
> > -        gprintk(XENLOG_WARNING, "NRip reported insn_len %lu\n", insn_len);
> > -    else if ( insn_len != 0 )
> > +        gprintk(XENLOG_WARNING, "NRip reported insn_len %lu\n", inst_len);
> 
> Since you are fixing this up anyway, insn_let in format string should
> also be updated.
> 
> With that,
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> 

Release-acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel