Re: [Xen-devel] [PATCH v1 3/7] ts-xen-build: Install livepatch regressions tests. [and 1 more messages]

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Konrad Rzeszutek Wilk writes ("[PATCH v1 3/7] ts-xen-build: Install livepatch 
regressions tests."):
> That come with the Xen git tree (see xen/test/).

I think this and the "build them" patch should be combined.

> +    buildcmd_stamped_logged(600, 'xen', 'tests-install', '',<<END,'') if 
> $dokconfig;

Can you keep the lines down to 75 characters or less please ?

> +        if test -d xen/test; then
> +           mkdir -p dist/install/usr/lib/debug
> +           livepatch_files=`find xen/test/livepatch -name '*.livepatch' 
> -print`
> +           cp \$livepatch_files dist/install/usr/lib/debug

Should this not be in the xen.git Makefiles ?

Also, the result of this is that the tests end up in the tools output
because you haven't fixed `divide'.  Background: each osstest
invocation of ts-xen-build produces two primary deliverables: `' and
`xen' aka `dist' and `xendist'.

I think, but I'm not sure, that these patches contain hypervisor code
and should be in `xendist'.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel