Re: [Xen-devel] [PATCH 2/2] libacpi: Be specific about which DSDT files to build

["Jan Beulich" <JBeulich@xxxxxxxx>]

> @@ -119,7 +119,7 @@ endif
>  clean: subdirs-clean
>       rm -f roms.inc roms.inc.new acpi.h
>       rm -f hvmloader hvmloader.tmp *.o $(DEPS)
> -     $(MAKE) -C $(ACPI_PATH)  ACPI_BUILD_DIR=$(CURDIR) clean
> +     $(MAKE) -C $(ACPI_PATH)  ACPI_BUILD_DIR=$(CURDIR) 
> DSDT_FILES="$(DSDT_FILES)" 

I think this could be left out - there's no issue cleaning up a wider set
of files. Namely during the transition just imagine someone running
a "clean" after having pulled your change.

> --- a/tools/libacpi/Makefile
> +++ b/tools/libacpi/Makefile
> @@ -21,9 +21,12 @@ endif
>  
>  MK_DSDT = $(ACPI_BUILD_DIR)/mk_dsdt
>  
> -C_SRC-$(CONFIG_X86) = dsdt_anycpu.c dsdt_15cpu.c dsdt_anycpu_qemu_xen.c
> +C_SRC-$(CONFIG_X86) = dsdt_anycpu.c dsdt_15cpu.c dsdt_anycpu_qemu_xen.c 
> dsdt_pvh.c
>  C_SRC-$(CONFIG_ARM_64) = dsdt_anycpu_arm.c
> -C_SRC = $(addprefix $(ACPI_BUILD_DIR)/, dsdt_pvh.c $(C_SRC-y))
> +ifeq ($(DSDT_FILES),)
> +DSDT_FILES = $(C_SRC-y)
> +endif

DSDT_FILES ?= $(C_SRC-y)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel