[Xen-devel] [PATCH Altp2m cleanup 2/3 v12 0/3] altp2m cleanup

[Paul Lai <paul.c.lai@xxxxxxxxx>]

The altp2m clean work is motivated by the following URLs:
   https://lists.xenproject.org/archives/html/xen-devel/2015-07/msg04454.html

Most of the work has been:
Lots of white space, indentation, and other coding style preference
corrections.
Lots of moving altp2m functions to the altp2m file.
Lots of moving ept functions to the ept file.
Fixing memory leaks in the hap_enable() memory allocation failures.


Paul Lai (3):
  Move altp2m specific functions to altp2m files.
  Altp2m cleanup: cleaning up partial memory allocations in
    hap_enable().
  Moving ept code to ept specific files.

 xen/arch/x86/mm/altp2m.c          | 55 +++++++++++++++++++++++++++++++++++
 xen/arch/x86/mm/hap/hap.c         | 61 ++++++++++++++++-----------------------
 xen/arch/x86/mm/p2m-ept.c         | 39 +++++++++++++++++++++++++
 xen/arch/x86/mm/p2m.c             | 43 ++-------------------------
 xen/include/asm-x86/altp2m.h      |  4 ++-
 xen/include/asm-x86/hvm/vmx/vmx.h |  3 ++
 xen/include/asm-x86/p2m.h         |  9 ++----
 7 files changed, 130 insertions(+), 84 deletions(-)

--
since v11

Fixed bug(s) in the memory leak error paths of hap_enable().
Consolidated the memory error path into a single code path for better
maintainability.
Created seperate patch for the memory error cleanup in hap_enable() for easier
backportability.

since v10

Removed the check for d == 0 at the head of altp2m_domain_init() per request.

Fixing code style issues missed in v10.  It was apparent that our eyes
are failing to see code style issues, so we started using some vim scripts
to assist.  Here's one for spaces after parens:
  pclai@pclaidev:/rhel-home/pclai/p2m_new/xen/output$ cat ~/vim_xen
  :highlight ForIfLParenNoSpace ctermbg=red guibg=red
  :highlight ForIfRParenNoSpace ctermbg=red guibg=red
  :match ForIfLParenNoSpace /['for''if'] ([a-zA-Z0-9]/
  :2match ForIfRParenNoSpace /['for''if'] .*[a-zA-Z0-9-+]+[)]$/

Here's another to catch dangling left curly braces:
  pclai@pclaidev:/rhel-home/pclai/p2m_new/xen/output$ cat ~/vim_xen_curly
  :highlight RParenCurly ctermbg=red guibg=red
  :match RParenCurly /) *[{]$/

We specifically unraval p2m_alloc_table() and hap_set_allocation() by
hand instead of calling p2m_teardown().
-- 
2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel