Re: [Xen-devel] [PATCH] libxl: fix gentypes call in Makefile

[Juergen Gross <jgross@xxxxxxxx>]

On 10/11/16 17:14, Cedric Bosdonnat wrote:
> On Thu, 2016-11-10 at 15:49 +0100, Juergen Gross wrote:
>> On 10/11/16 14:11, Cédric Bosdonnat wrote:
>>> From the make documentation:
>>>
>>> "$* [...] If the target is `dir/a.foo.b' and the target pattern is
>>> `a.%.b' then the stem is `dir/foo'. In a static pattern rule, the
>>> stem is part of the file name that matched the `%' in the target
>>> pattern."
>>>
>>> The rule generating the c types files from the idl ones is not
>>> a static pattern rule, but rather an implicit rule. Thus the value
>>> of $* is preceded by the file path, instead of only what matches %.
>>>
>>> In order to get this fixed, drop the path using a $(shell basename $*).
>>
>> Why not $(notdir $*) ?
> 
> Just because I wasn't aware of it. But of course, I can change to it:
> it's surely a more portable solution

And it spares two processes.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel