Re: [Xen-devel] [PATCH 06/10] acpi: PVH guests need _E02 method

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Sun, Nov 06, 2016 at 04:42:39PM -0500, Boris Ostrovsky wrote:
> This is the method that will get invoked on an SCI.
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>


.. thought I wonder - do you want to also make the writes to
_GPE.DPT1 and _GPE.DPT2 be optional? Looking at the mk_dsdt.c
those are defined at 0xb044 and are done in:
 /**** PCI0 start ****/ 

aka:

  stmt("OperationRegion", "DG1, SystemIO, 0xb044, 0x04");                     
415                                                                             
    
416     push_block("Field", "DG1, ByteAcc, NoLock, Preserve");                  
    
417     indent(); printf("DPT1, 8, DPT2, 8\n");                                 
    
418     pop_block();                                     

Which means if you run 'acpixtract' and 'acpixecute' to play with
the DSDTs you will get nasty warnings about the DPT1 and DPT2 not being
defined.

I am actually not sure what the kernel will do with undefind DPT1 and DPT2?
I would have thought the iasl compiler would throw an nasty fit?

> ---
>  tools/libacpi/mk_dsdt.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/libacpi/mk_dsdt.c b/tools/libacpi/mk_dsdt.c
> index 4ae68bc..407386a 100644
> --- a/tools/libacpi/mk_dsdt.c
> +++ b/tools/libacpi/mk_dsdt.c
> @@ -280,11 +280,6 @@ int main(int argc, char **argv)
>  
>      pop_block();
>  
> -    if (dm_version == QEMU_NONE) {
> -        pop_block();
> -        return 0;
> -    }
> -
>      /* Define GPE control method. */
>      push_block("Scope", "\\_GPE");
>      push_block("Method",
> @@ -292,6 +287,11 @@ int main(int argc, char **argv)
>      stmt("\\_SB.PRSC ()", NULL);
>      pop_block();
>      pop_block();
> +
> +    if (dm_version == QEMU_NONE) {
> +        pop_block();
> +        return 0;
> +    }
>      /**** Processor end ****/
>  
>  
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> https://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel