Re: [Xen-devel] [PATCH] x86/traps: replace ASSERT() checking array bounds

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 07/11/16 09:25, Jan Beulich wrote:
> Avoid out of bounds accesses on non-debug builds.
>
> Coverity ID: 1055744
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

>
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -3764,7 +3764,11 @@ void async_exception_cleanup(struct vcpu
>              if ( (curr->async_exception_mask ^
>                    curr->async_exception_state(trap).old_mask) == (1 << trap) 
> )
>                  break;
> -    ASSERT(trap <= VCPU_TRAP_LAST);
> +    if ( unlikely(trap > VCPU_TRAP_LAST) )
> +    {
> +        ASSERT_UNREACHABLE();
> +        return;
> +    }
>  
>      /* Restore previous asynchronous exception mask. */
>      curr->async_exception_mask = curr->async_exception_state(trap).old_mask;
>
>
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel