Re: [Xen-devel] [PATCH for-4.8 2/2] Config.mk: fix comment for debug option

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Wei Liu <wei.liu2@xxxxxxxxxx> 11/01/16 5:38 PM >>>
>On Tue, Nov 01, 2016 at 10:33:54AM -0600, Jan Beulich wrote:
>> >>> Wei Liu <wei.liu2@xxxxxxxxxx> 11/01/16 5:20 PM >>>
>> >On Tue, Nov 01, 2016 at 10:18:46AM -0600, Jan Beulich wrote:
>> >> >>> Wei Liu <wei.liu2@xxxxxxxxxx> 11/01/16 2:48 PM >>>
>> >> >config/StdGNU.mk | 8 --------
>> >> >config/SunOS.mk  | 7 -------
>> >> >tools/Rules.mk   | 4 +++-
>> >> >xen/Rules.mk     | 6 ++++++
>> >> >4 files changed, 9 insertions(+), 16 deletions(-)
>> >> 
>> >> Considering this diffstat - did the original global settings not get 
>> >> inherited
>> >> by any of the other subtrees, namely stubdom/ and/or extras/ ?
>> > 
>> >I mentioned this in commit message and deliberately made the decision to
>> >not inherit these flags for stubdom build.
>> 
>> Indeed, I've overlooked that part, but I'm not fully convinced. And then
>
>Not fully convinced because? Can you be more specific?

I don't know very much about the stubdom build machinery, but I could
easily imaging some top level setting to have made it through to some
of the sub-components, in which case this change would have a
functional impact.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel