Re: [Xen-devel] [PATCH] x86/svm: Improve segment register printing in svm_vmcb_dump()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 31/10/16 14:12, Jan Beulich wrote:
>>>> On 31.10.16 at 14:48, <andrew.cooper3@xxxxxxxxxx> wrote:
>> --- a/xen/arch/x86/hvm/svm/svmdebug.c
>> +++ b/xen/arch/x86/hvm/svm/svmdebug.c
>> @@ -20,11 +20,10 @@
>>  #include <asm/msr-index.h>
>>  #include <asm/hvm/svm/svmdebug.h>
>>  
>> -static void svm_dump_sel(const char *name, svm_segment_register_t *s)
>> +static void svm_dump_sel(const char *name, const svm_segment_register_t *s)
>>  {
>> -    printk("%s: sel=0x%04x, attr=0x%04x, limit=0x%08x, base=0x%016llx\n", 
>> -           name, s->sel, s->attr.bytes, s->limit,
>> -           (unsigned long long)s->base);
>> +    printk("%s: %04x %05x %08x %016"PRIx64"\n",
>> +           name, s->sel, s->attr.bytes, s->limit, s->base);
> Why do you change to 5 digits for the attributes? Other than VMX,
> SVM has nothing defined beyond bit 15.

Good point - I blindly copied the VMX side without adjusting.  Will fix.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel