Re: [Xen-devel] [PATCH v3 for-4.8] libelf: fix symtab/strtab loading for 32bit domains

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.10.16 at 15:25, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 13/10/16 13:48, Roger Pau Monne wrote:
>> diff --git a/xen/include/xen/libelf.h b/xen/include/xen/libelf.h
>> index 90bd8cb..70abbaf 100644
>> --- a/xen/include/xen/libelf.h
>> +++ b/xen/include/xen/libelf.h
>> @@ -432,6 +432,16 @@ struct elf_dom_parms {
>>      uint64_t virt_kend;
>>  };
>>  
>> +/* Number of section header needed in order to fit the SYMTAB and STRTAB. 
> */
>> +#define ELF_BSDSYM_SECTIONS 3
>> +struct elf_sym_header {
>> +    uint32_t size;
>> +    struct {
>> +        elf_ehdr header;
>> +        elf_shdr section[ELF_BSDSYM_SECTIONS];
>> +    } elf_header;
>> +} __attribute__((packed));
> 
> __packed please, rather than opencoding it.  Also, should be between
> struct and the structure name.

There's no __packed in libxc afaics, and the code here is shared.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel