Re: [Xen-devel] [PATCH v4 1/2] gcov: add new interface and new formats support

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Oct 13, 2016 at 07:05:21AM -0600, Jan Beulich wrote:
> >>> On 13.10.16 at 14:04, <wei.liu2@xxxxxxxxxx> wrote:
> > A new sysctl interface for passing gcov data back to userspace. The new
> > interface uses a customised record file format. The new sysctl reuses
> > original sysctl number but renames the op to gcov_op.
> > 
> > Formats starting from gcc version 3.4 are supported. The code is
> > rewritten so that a new format can be easily added in the future.
> > Version specific code is grouped into different files. The format one
> > needs to use can be picked via Kconfig. The default format is the newest
> > one.
> > 
> > Userspace programs to handle extracted data will come in a later patch.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> with one suggestion and one further adjustment:
> 
> > --- /dev/null
> > +++ b/xen/common/gcov/gcc_4_9.c
> > @@ -0,0 +1,35 @@
> > +/*
> > + *  This code provides functions to handle gcc's profiling data format
> > + *  introduced with gcc 4.7.
> > + *
> > + *  This file is based heavily on gcc_3_4.c file.
> 
> I think this is not really applicable here and in gcc_5.c.

OK. I will delete this.

> 
> > + *
> > + *  For a better understanding, refer to gcc source:
> > + *  gcc/gcov-io.h
> > + *  libgcc/libgcov.c
> > + *
> > + *  Uses gcc-internal data definitions.
> > + *
> > + *  Imported from Linux and modified for Xen by
> > + *    Wei Liu <wei.liu2@xxxxxxxxxx>
> > + */
> > +
> > +#include "gcov.h"
> > +
> > +#if !(GCC_VERSION >= 40900 && GCC_VERSION < 50100)
> 
> This wants to be 50000 now on the right side, afaict.
> 

Right. I missed this one place. I will fix it.

Thanks for your careful review.

Wei.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel