Re: [Xen-devel] [PATCH 2/2] x86/vmx: Reduce the verbosity of the vmentry failure error reporting

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.10.16 at 13:15, <andrew.cooper3@xxxxxxxxxx> wrote:
> Identify the affected vcpu at the start of the message.  While tweaking this
> area, add extra newlines between cases.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with ...

> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -3096,19 +3096,20 @@ static void vmx_failed_vmentry(unsigned int 
> exit_reason,
>      unsigned long exit_qualification;
>      struct vcpu *curr = current;
>  
> -    printk("Failed vm entry (exit reason %#x) ", exit_reason);
> +    printk("%pv vmentry failure (reason %#x): ", curr, exit_reason);
>      __vmread(EXIT_QUALIFICATION, &exit_qualification);
>      switch ( failed_vmentry_reason )
>      {
>      case EXIT_REASON_INVALID_GUEST_STATE:
> -        printk("caused by invalid guest state (%ld).\n", exit_qualification);
> +        printk("Invalid guest state (%ld)\n", exit_qualification);

... %lu here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel