[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v9 06/13] efi: create new early memory allocator
- To: Jan Beulich <JBeulich@xxxxxxxx>, Daniel Kiper <daniel.kiper@xxxxxxxxxx>
- From: Julien Grall <julien.grall@xxxxxxx>
- Date: Wed, 5 Oct 2016 11:30:59 -0700
- Cc: Juergen Gross <JGross@xxxxxxxx>, sstabellini@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, cardoe@xxxxxxxxxx, pgnet.dev@xxxxxxxxx, ning.sun@xxxxxxxxx, david.vrabel@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, qiaowei.ren@xxxxxxxxx, gang.wei@xxxxxxxxx, fu.wei@xxxxxxxxxx
- Delivery-date: Wed, 05 Oct 2016 18:31:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
Hi Jan,
Sorry for the late answer, I have been traveling the past 2 weeks.
On 30/09/2016 02:46, Jan Beulich wrote:
On 29.09.16 at 23:42, <daniel.kiper@xxxxxxxxxx> wrote:
+#else
+static void __init free_ebmalloc_unused_mem(void)
+{
+}
+#endif
Did you build test this for ARM? The function ought to be unused,
as ...
@@ -1251,6 +1301,8 @@ void __init efi_init_memory(void)
} *extra, *extra_head = NULL;
#endif
+ free_ebmalloc_unused_mem();
... the whole function here doesn't get built on ARM.
Julien - we're still awaiting your input on general aspects here.
efi_init_memory would need to be called during Xen boot on ARM. I am not
sure where as I we don't yet have runtime support on ARM.
Other than that, the patch looks good to me.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
