Re: [Xen-devel] [PATCH 2/5] x86emul: consolidate segment register handling

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.09.16 at 12:39, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 08/09/16 14:43, Jan Beulich wrote:
>> @@ -2861,21 +2860,20 @@ x86_emulate(
>>          dst.val = src.val;
>>          break;
>>  
>> -    case 0x8c: /* mov Sreg,r/m */ {
>> -        struct segment_register reg;
>> -        enum x86_segment seg = decode_segment(modrm_reg);
>> +    case 0x8c: /* mov Sreg,r/m */
>> +        seg = decode_segment(modrm_reg);
>>          generate_exception_if(seg == decode_segment_failed, EXC_UD, -1);
>> +    store_seg:
> 
> store_seg is easy to confuse with load_seg.  How about read_selector
> instead?

Well - it was specifically meant to match up with load_seg. I dislike
read_selector (specifically because the read part of the operation
was done by the time we get here), but if you like store_selector
better than store_seg, I could use that one.

> It also occurs to me that you might have an easier time with both this
> patch and patch 1 if you reversed their order.

Yes, but that's the order they came to life in, and I then didn't
want to bother switching them around.

>  Either way, Reviewed-by:
> Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel