Re: [Xen-devel] [PATCH v9 06/13] efi: create new early memory allocator

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Fri, Sep 30, 2016 at 03:46:54AM -0600, Jan Beulich wrote:
> >>> On 29.09.16 at 23:42, <daniel.kiper@xxxxxxxxxx> wrote:
> > +#else
> > +static void __init free_ebmalloc_unused_mem(void)
> > +{
> > +}
> > +#endif
>
> Did you build test this for ARM? The function ought to be unused,
> as ...

Nope.

> > @@ -1251,6 +1301,8 @@ void __init efi_init_memory(void)
> >      } *extra, *extra_head = NULL;
> >  #endif
> >
> > +    free_ebmalloc_unused_mem();
>
> ... the whole function here doesn't get built on ARM.

Err... I thought that it does somehow. It looks that at least
one test build is always good idea.

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel