Re: [Xen-devel] [PATCH v2 08/10] libxl: fix coding style of credit1 parameters related functions

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Dario Faggioli writes ("[PATCH v2 08/10] libxl: fix coding style of credit1 
parameters related functions"):
> More specifically, the the error handling path is
> made compliant with libxl's codying style.
...
>  int libxl_sched_credit_params_set(libxl_ctx *ctx, uint32_t poolid,
>                                    libxl_sched_credit_params *scinfo)
>  {
>      struct xen_sysctl_credit_schedule sparam;
> -    int rc=0;
> +    int r, rc;
...
>  
>      scinfo->tslice_ms = sparam.tslice_ms;
>      scinfo->ratelimit_us = sparam.ratelimit_us;
>  
> + out:
>      GC_FREE;
> -    return 0;
> +    return rc;

I think this is missing an assignment

  rc = 0;

on the successful exit path, just before out.  Am I wrong ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel