Re: [Xen-devel] [PATCH v8 06/13] efi: create new early memory allocator

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.09.16 at 00:51, <daniel.kiper@xxxxxxxxxx> wrote:
> v8 - suggestions/fixes:
>    - disable whole ebmalloc machinery on ARM platforms,

This is certainly not in line with my understanding of the outcome of
that discussion.

> --- a/xen/arch/x86/efi/stub.c
> +++ b/xen/arch/x86/efi/stub.c
> @@ -9,6 +9,8 @@ bool efi_enabled(unsigned int feature)
>      return false;
>  }
>  
> +void __init free_ebmalloc_unused_mem(void) { }
> +
>  void __init efi_init_memory(void) { }

Looking at this I wonder - can't the freeing be put into
efi_init_memory()?

> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -98,6 +98,56 @@ static CHAR16 __initdata newline[] = L"\r\n";
>  #define PrintStr(s) StdOut->OutputString(StdOut, s)
>  #define PrintErr(s) StdErr->OutputString(StdErr, s)
>  
> +#ifndef CONFIG_ARM
> +
> +/*
> + * TODO: Enable EFI boot allocator on ARM.
> + * This code can be common for x86 and ARM.
> + * Things TODO on ARM before enabling ebmalloc:
> + *   - estimate required EBMALLOC_SIZE value,
> + *   - where (in which section) ebmalloc_mem[]
> + *     should live; if in .bss.page_aligned
> + *     then whole BSS zeroing have to be
> + *     disabled in xen/arch/arm/arm64/head.S;
> + *     though BSS should be initialized somehow
> + *     before use of variables living there,
> + *   - add free_ebmalloc_unused_mem() call to
> + *     e.g. xen/arch/arm/setup.c:init_done().
> + */

Please make better use of line length in such longer comments -
the longest line here ends at column 48 or so.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel