Re: [Xen-devel] [PATCH] x86emul: correct loading of %ss

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.09.16 at 15:40, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 21/09/16 10:05, Jan Beulich wrote:
>> @@ -1248,7 +1254,6 @@ protmode_load_seg(
>>  
>>      dpl = (desc.b >> 13) & 3;
>>      rpl = sel & 3;
> 
> ... it occurs to me that the calculation of rpl can be moved up to its
> declaration, which allows you to check (cpl == 3) || (cpl != rpl) rather
> than sel, which is more clearly correct IMO.

I think I prefer to leave this alone for the moment.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel