Re: [Xen-devel] [PATCH 2/2] x86/vm_event: Allow returning i-cache for emulation

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 09/16/16 18:37, Tamas K Lengyel wrote:
>>>>> Since this breaks compilation of existing clients, I think we should
>>>>> >>>> increment some macro to alow for compile-time switching (maybe
>>>>> >>>> VM_EVENT_INTERFACE_VERSION?).
>>>> >>>
>>>> >>> I'm not sure I follow - this is a Xen internal-only enumeration. What
>>>> >>> kind-of clients are you referring to?
>>> >>
>>> >> Nevermind, I thought these changes propagate to the toolstack headers.
>>> >> Sorry for the confusion.
>> >
>> > On second thought (and a night's rest), the problem is real. I've made
>> > it a point to test the patches today before re-reviewing them, and this
>> > happened:
>> >
>> > bdvmixeneventmanager.cpp:359:46: error: ‘union vm_event_st::<anonymous>’
>> > has no member named ‘emul_read_data’
>> >       uint32_t rspDataSize = sizeof( rsp.data.emul_read_data.data );
>> >                                               ^
>> > bdvmixeneventmanager.cpp:386:44: error: ‘union vm_event_st::<anonymous>’
>> > has no member named ‘emul_read_data’
>> >                            action, rsp.data.emul_read_data.data,
>> > rspDataSize,
>> >                                             ^
>> > bdvmixeneventmanager.cpp:389:16: error: ‘union vm_event_st::<anonymous>’
>> > has no member named ‘emul_read_data’
>> >        rsp.data.emul_read_data.size = rspDataSize;
>> >                 ^
>> > make: *** [bdvmixeneventmanager.o] Error 1
>> >
>> > So, as you can see, existing clients really don't compile without
>> > modification.
>> >
> Hi Razvan,
> yes, for Xen 4.8 we already bumped the VM_EVENT_INTERFACE_VERSION, so
> any client building on it need to adapt accordingly.

Fair enough. That's all I was asking for / about: that we should make
sure that VM_EVENT_INTERFACE_VERSION reflects these changes. If it's
already been incremented for this pending release, that's perfect.


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel