Re: [Xen-devel] [PATCH 1/2] x86: add a user configurable Kconfig option for the NS16550 UART

[Julien Grall <julien.grall@xxxxxxx>]

Hello Derek,

On 13/09/16 18:35, Derek Straka wrote:
> Allows for the conditional inclusion of NS16550 UART driver on the x86 platform
> rather than having it always enabled.
>
> The default configuration for the HAS_NS16550 option remains 'y' on x86, so the
> behavior out of the box remains unchanged.  The addition of the option allows
> advanced users to enable/disable the inclusion of the NS16550 UART driver.
>
> Signed-off-by: Derek Straka <derek@xxxxxxxxxxx>
> ---
>  xen/arch/x86/Kconfig     | 1 -
>  xen/drivers/char/Kconfig | 4 ++--
>  xen/include/xen/serial.h | 7 ++++++-
>  3 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
> index 265fd79..8a122df 100644
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -15,7 +15,6 @@ config X86
>         select HAS_MEM_ACCESS
>         select HAS_MEM_PAGING
>         select HAS_MEM_SHARING
> -       select HAS_NS16550
>         select HAS_PASSTHROUGH
>         select HAS_PCI
>         select HAS_PDX
> diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
> index 51343d0..c87e018 100644
> --- a/xen/drivers/char/Kconfig
> +++ b/xen/drivers/char/Kconfig
> @@ -1,6 +1,6 @@
>  config HAS_NS16550
> -       bool
> -       default y
> +       bool "NS16550 UART" if EXPERT = "y"
> +       default y if X86
>         help
>           This selects the 16550-series UART support. For most systems, say Y.
With this change, NS166550 is now disabled by default on ARM. This was 
not the case before.
Please make sure to retain the previous behavior for ARM platforms.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel