Re: [Xen-devel] [PATCH] libelf: drop pointless uses of __FUNCTION__

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Jan Beulich writes ("[PATCH] libelf: drop pointless uses of __FUNCTION__"):
> Non-debugging message text should be (and is in the cases here, albeit
> often only with the addition of an ELF: prefix) distinguishable without
> also logging function names.
> 
> In the messages touched at once use %#x (or variants thereof) in favor
> of 0x%x.
...
> -        elf_msg(elf, "%s: %s = \"%s\"\n", __FUNCTION__,
> -                note_desc[type].name, str);

I think this should say "%s: ELF note %s = ...", so that it is not
ambiguous.  There are lots of this pattern.

Previously the messages were mostly-unambiguous because of
__FUNCTION__.  In the general case, in such situations, they should be
disambiguated in your patch by adding suitable literal text.

I looked through the rest of the patch and the ELF notes seem to be
the only ambiguous case.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel