Re: [Xen-devel] [PATCH V3] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.09.16 at 16:21, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> On 09/06/2016 05:07 PM, Jan Beulich wrote:
>>>>> On 06.09.16 at 12:00, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>>> --- a/xen/arch/arm/p2m.c
>>> +++ b/xen/arch/arm/p2m.c
>>> @@ -1836,6 +1836,15 @@ long p2m_set_mem_access(struct domain *d, gfn_t gfn, 
>>> uint32_t nr,
>>>      return 0;
>>>  }
>>>  
>>> +long p2m_set_mem_access_multi(struct domain *d,
>>> +                              const XEN_GUEST_HANDLE(const_uint64) 
>>> pfn_list,
>>> +                              const XEN_GUEST_HANDLE(const_uint8) 
>>> access_list,
>>> +                              uint32_t nr, uint32_t start, uint32_t mask,
>>> +                              unsigned int altp2m_idx)
>>> +{
>>> +    return -ENOTSUP;
>>> +}
>> 
>> If this indeed fixes the build problem on ARM, then I'd like to have an
>> explanation (by you or the ARM maintainers) where ENOTSUP gets
>> defined. I can't find any single instance of this throughout the tree,
>> and headers outside of the tree aren't supposed to get included in
>> the hypervisor build.
> 
> It's defined in errno.h, which some in-tree files do include, but as
> stated I don't, at the moment, have access to an ARM setup, so it is
> theoretically possible that the code still doesn't compile on ARM. I
> thought it would, since it's trivial.

I can't find any inclusion of plain errno.h (apart in tools built to aid
the building process). There are xen/errno.h and, public/errno.h,
but those - afaics - don't define ENOTSUP.

> I won't send the next version until it becomes possible for me to at
> least compile it on ARM.

Indeed, compile testing is the minimal requirement.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel