Re: [Xen-devel] [PATCH v2 10/20] arm64/insn: introduce aarch64_insn_gen_{nop|branch_imm}() helper functions

[Julien Grall <julien.grall@xxxxxxx>]

Hi Konrad,

On 25/08/16 14:37, Konrad Rzeszutek Wilk wrote:
> This is copied from Linux 4.7, and the initial commit
> that put this in is 5c5bf25d4f7a950382f94fc120a5818197b48fe9
> "arm64: introduce aarch64_insn_gen_{nop|branch_imm}() helper functions"
>
> This lays the groundwork for Livepatch to generate the
> trampoline to jump to the new replacement function.
> Also allows us to NOP the callsites.
>
> This lays the groundwork for Livepatch to generate the
> trampoline to jump to the new replacement function.
> And also to NOP insns.
NIT: Both paragraphs seem to stay the same things. Did you mean to keep 
only one?
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
The rest of the patch looks good:

Acked-by: Julien Grall <julien.grall@xxxxxxx>

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel