Re: [Xen-devel] [PATCH v2 1/2] tools: remove blktap2 related code and documentation

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[PATCH v2 1/2] tools: remove blktap2 related code and 
documentation"):
> Blktap2 is effectively dead code for a few years.
> 
> Notable changes in this patch:
> 
> 0. Unhook blktap2 from build system
> 1. Now libxl no longer supports TAP disk backend, appropriate assertions
>    are added and some code paths now return ERROR_FAIL
> 2. Tap is no longer a supported backend in doc
> 3. Remove relevant entries in MAINTAINERS
> 
> A patch to actually remove blktap2 directory will come later.

The change to libxl seems OK to me, although:

> This version is tested: libxl bails when trying to set backend to tap.

What error message and error code do you get ?  If we're removing
this, we should make sure that the error message makes sense.

All the rest is fine by me.  But we should wait a bit more to see if
anyone objects IMO.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel