Re: [Xen-devel] [PATCH v4 00/16] Xen ARM DomU ACPI support

[Julien Grall <julien.grall@xxxxxxx>]

Hi Wei,

On 24/08/2016 08:58, Wei Liu wrote:
> On Tue, Aug 16, 2016 at 06:24:57PM +0800, Shannon Zhao wrote:
> > From: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> >
> > The design of this feature is described as below.
> > Firstly, the toolstack (libxl) generates the ACPI tables according the
> > number of vcpus and gic controller.
> >
> > Then, it copies these ACPI tables to DomU non-RAM memory map space and
> > passes them to UEFI firmware through the "ARM multiboot" protocol.
> >
> > At last, UEFI gets the ACPI tables through the "ARM multiboot" protocol
> > and installs these tables like the usual way and passes both ACPI and DT
> > information to the Xen DomU.
> >
> > Currently libxl only generates RSDP, XSDT, GTDT, MADT, FADT, DSDT tables
> > since it's enough now.
> >
> > This has been tested using guest kernel with the Dom0 ACPI support
> > patches which could be fetched from linux master or:
> > https://git.kernel.org/cgit/linux/kernel/git/mfleming/efi.git/log/?h=efi/arm-xen
> >
> > The UEFI binary could be fetched from or built from edk2 master branch:
> > http://people.linaro.org/~shannon.zhao/DomU_ACPI/XEN_EFI.fd
> >
> > This series can be fetched from:
> > https://git.linaro.org/people/shannon.zhao/xen.git  domu_acpi_v4
> Thanks for posting this version and sorry for the late review.
>
> I've skimmed the whole series and pointed out things I think should be
> improved. I will leave reviewing all the table building code to ARM
> maintainers.
I looked at the tables, they look good to me. Although, I made few 
comments on various place.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel