Re: [Xen-devel] [PATCH 1/3] mini-os: cleanup x86_32.S

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Juergen Gross, on Fri 26 Aug 2016 16:35:34 +0200, wrote:
> arch/x86/x86_32.S has some superfluous instructions. Remove them.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

These are indeed remnants from the past.

Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

> ---
>  arch/x86/x86_32.S | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/arch/x86/x86_32.S b/arch/x86/x86_32.S
> index f70fc65..3de0027 100644
> --- a/arch/x86/x86_32.S
> +++ b/arch/x86/x86_32.S
> @@ -111,7 +111,6 @@ do_exception:
>      jmp ret_from_exception
>      
>  ret_from_exception:
> -    movb CS(%esp),%cl
>      addl $8,%esp
>      RESTORE_ALL
>  
> @@ -140,11 +139,7 @@ ENTRY(hypervisor_callback)
>          call do_hypervisor_callback
>          add  $4,%esp
>          movl HYPERVISOR_shared_info,%esi
> -        xorl %eax,%eax
> -        movb CS(%esp),%cl
> -     test $2,%cl          # slow return to ring 2 or 3
> -        jne  safesti
> -safesti:movb $0,1(%esi)     # reenable event callbacks
> +        movb $0,1(%esi)     # reenable event callbacks
>  scrit:  /**** START OF CRITICAL REGION ****/
>          testb $0xFF,(%esi)
>          jnz  14f              # process more events if necessary...
> -- 
> 2.6.6
> 

-- 
Samuel
 >       ±z¬O§_¸g±`¬°¦p¦ó©Ý®i¦æ¾PºÞ¹D¶Ë¸£µ¬?
 > ¥Zµn³ø¯È,Âø»x¼s§i©Î¶l±H¢Ò¢Û (Direct Mail)¬O§_¤w¸gµLªk¹F¦¨±z¹w´Áªº¼s§i®ÄªG?
 Je vous invite a consulter dans un premier temps le french-Howto.
 -+- JCD in Guide du linuxien pervers - "Bien configurer la lisibilité de fcolm"

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel