[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 01/16] x86: allow EFI reboot method neither on EFI platforms...



>>> On 20.08.16 at 00:43, <daniel.kiper@xxxxxxxxxx> wrote:
> ..nor EFI platforms with runtime services enabled.
> 
> Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> ---
> v5 - suggestions/fixes:
>    - fix build error
>      (suggested by Jan Beulich),
>    - improve commit message.

Not really - it is now stale, as there's no checking of whether runtime
service use is allowed. I also don't see what change in behavior this
patch brings when viewed on its own. I think instead of fixing the
prior build error you'd better have moved this later in the series.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.