Re: [Xen-devel] [PATCH v4 01/16] tools/libxl: Add an unified configuration option for ACPI

[Shannon Zhao <zhaoshenglong@xxxxxxxxxx>]

On 2016/8/24 20:50, Wei Liu wrote:
>> -        localents[i++] = libxl_defbool_val(info->u.hvm.acpi) ? "1" : "0";
>> > +        localents[i++] = (libxl_defbool_val(info->acpi) &&
>> > +                         libxl_defbool_val(info->u.hvm.acpi)) ? "1" : "0";
> Please provide a function for this.
> 
> And the logic doesn't seem right. If the user sets u.hvm.acpi only,
> (s)he should still have ACPI enabled.
info->acpi is true by defaut, so if user doesn't set info->acpi while
sets u.hvm.acpi only, both u.hvm.acpi and info->acpi will be true IIUC.

Thanks,
-- 
Shannon


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel