Re: [Xen-devel] [PATCH 06/22] mini-os: setup hypercall page for HVMlite

[Juergen Gross <jgross@xxxxxxxx>]

On 23/08/16 23:03, Samuel Thibault wrote:
> hello,
> 
> Juergen Gross, on Tue 23 Aug 2016 17:15:52 +0200, wrote:
>> When running in HVMlite mode we need to setup the hypercall page by
>> ourself.
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>> ---
>>  
>> +#else /* ifdef __x86_64__ */
>> +#error "Unsupported architecture"
>> +#endif
>> +
>>  #define wrmsr(msr,val1,val2) \
>>        __asm__ __volatile__("wrmsr" \
>>                             : /* no outputs */ \
>>                             : "c" (msr), "a" (val1), "d" (val2))
>>  
>> -#define wrmsrl(msr,val) 
>> wrmsr(msr,(uint32_t)((uint64_t)(val)),((uint64_t)(val))>>32)
>> +static inline void wrmsrl(unsigned msr, uint64_t val)
>> +{
>> +    wrmsr(msr, (uint32_t)(val & 0xffffffffULL), (uint32_t)(val >> 32));
>> +}
>>  
>> -
>> -#else /* ifdef __x86_64__ */
>> -#error "Unsupported architecture"
>> -#endif
>>  #endif /* ifdef __INSIDE_MINIOS */
> 
> Then please move it after
> 
>>  /********************* common i386 and x86_64  ****************************/
> 
> This line :)

Okay.

> 
> Apart from that, 
> 
> Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

Thanks,

Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel