[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v4 08/16] kbuild: enable option to force compile force-obj-y and force-lib-y
- To: Kees Cook <keescook@xxxxxxxxxxxx>, Michal Marek <mmarek@xxxxxxxx>
- From: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>
- Date: Tue, 23 Aug 2016 01:59:10 +0200
- Cc: "gnomes@xxxxxxxxxxxxxxxxxxx" <gnomes@xxxxxxxxxxxxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, Jiri Kosina <jkosina@xxxxxxx>, "benh@xxxxxxxxxxxxxxxxxxx" <benh@xxxxxxxxxxxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxxxxx>, Heiko Carstens <heiko.carstens@xxxxxxxxxx>, platform-driver-x86@xxxxxxxxxxxxxxx, James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>, linux-arch <linux-arch@xxxxxxxxxxxxxxx>, markus.heiser@xxxxxxxxxxx, sparclinux <sparclinux@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>, linux-sh <linux-sh@xxxxxxxxxxxxxxx>, Will Deacon <will.deacon@xxxxxxx>, 조경민 <korea.drzix@xxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, anil.s.keshavamurthy@xxxxxxxxx, fontana@xxxxxxxxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, dvhart@xxxxxxxxxxxxx, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, David Vrabel <david.vrabel@xxxxxxxxxx>, linux-xtensa@xxxxxxxxxxxxxxxx, pali.rohar@xxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, Miao Steven <realmz6@xxxxxxxxx>, Jani Nikula <jani.nikula@xxxxxxxxx>, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, jbaron@xxxxxxxxxx, ananth@xxxxxxxxxxxxxxxxxx, Borislav Petkov <bp@xxxxxxxxx>, Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Michael Brown <mcb30@xxxxxxxx>, linux-kbuild <linux-kbuild@xxxxxxxxxxxxxxx>, Alan Cox <alan@xxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Chris Zankel <chris@xxxxxxxxxx>, Paul Bolle <pebolle@xxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, "ananth@xxxxxxxxxx" <ananth@xxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxxxxxxxxxxx>, "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>, Mark Salter <msalter@xxxxxxxxxx>, mhiramat@xxxxxxxxxx, jolsa@xxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
- Delivery-date: Mon, 22 Aug 2016 23:59:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Fri, Aug 19, 2016 at 03:10:33PM -0700, Kees Cook wrote:
> On Fri, Aug 19, 2016 at 2:32 PM, <mcgrof@xxxxxxxxxx> wrote:
> > diff --git a/init/Kconfig b/init/Kconfig
> > index cac3f096050d..ef09e83b9196 100644
> > --- a/init/Kconfig
> > +++ b/init/Kconfig
> > @@ -53,6 +53,28 @@ config CROSS_COMPILE
> > need to set this unless you want the configured kernel build
> > directory to select the cross-compiler automatically.
> >
> > +config BUILD_AVOID_BITROT
> > + bool "Enable force building of force-obj-y and force-lib-y"
>
> Sorry to continue the bikeshedding on this, but if I encounter
> something in a Makefile named "force-obj-y" I would expect it to
> always be built, no matter what. But this is not the case: the
> "force-" prefix is tied to this CONFIG_BUILD_AVOID_BITROT. This verb
> usage is weird, as I'd expect an adjective, like "forceable-obj-y" or
> something that describes that it CAN be built even with the CONFIG for
> it is missing, etc.
>
> Regardless, I defer to Michal on this, but I'm not a fan of "force"
> being used when it's an optional action. :)
Sure, Michal let me know if forceable-obj-y and forceable-lib-y is the
way to go.
Luis
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|