Re: [Xen-devel] [PATCH] x86: Add a tboot Kconfig option

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.08.16 at 14:06, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 17/08/16 19:17, Derek Straka wrote:
>> Allows for the conditional inclusion of tboot related functionality via 
>> Kconfig
>>
>> The default configuration for the new CONFIG_TBOOT option is 'y', so the
>> behavior out of the box remains unchanged.  The addition of the option allows
>> advanced users to disable system behaviors associated with tboot at compile
>> time rather than relying on the run-time detection and configuration.

You say "advanced users" here, yet ...

>> +config TBOOT
>> +    bool "Xen tboot support"
>> +    default y
>> +    depends on X86

... there's no dependency on EXPERT here. User selectable options
not depending on EXPERT need extra good reasoning on why they
need to be that way.

>> @@ -127,6 +128,17 @@ int tboot_parse_dmar_table(acpi_table_handler 
>> dmar_handler);
>>  int tboot_s3_resume(void);
>>  void tboot_s3_error(int error);
>>  int tboot_wake_ap(int apicid, unsigned long sipi_vec);
>> +#else
>> +static inline void tboot_probe(void) {}
>> +static inline void tboot_shutdown(uint32_t shutdown_type) {}
>> +static inline int tboot_in_measured_env(void) {return 0;}
>> +static inline int tboot_protect_mem_regions(void) {return 1;}
>> +static inline int tboot_parse_dmar_table(acpi_table_handler dmar_handler) 
>> {return acpi_table_parse(ACPI_SIG_DMAR, dmar_handler);}
> 
> Please include spaces immediately inside the braces.

And the last one looks to be an overly long line.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel